-
-
Notifications
You must be signed in to change notification settings - Fork 4
Make this crate no_std #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Ah oops, that works in nightly but doesn’t yet in stable, due to |
I think a |
There, I have added an optional but enabled by default |
Can you also update the CI logic to also test with the std feature disabled? LGTM otherwise |
074d7bc
to
92838fd
Compare
Hi, sorry for the delay, but in the meantime |
I think it'd be safer to have an enabled-by-default |
Hi, sorry for the very long delay, I’ve added back the std feature to support Rust versions older than 1.81.0, although nowadays that’s a bit old and most of the ecosystem won’t build on such ancient versions any longer. I’ve added a test in CI for |
52f5cfc
to
8d6d2d1
Compare
This allows users such as the jid crate to actually be no_std as well. core::error::Error got stabilized back in Rust 1.81.0, but in order to support older Rust versions we added a std feature.
As nothing actually depends on
std
, there is no need to keep a dependency on it. This allows users such as the jid crate to actually beno_std
as well.